[Security]: Prevent persisting the remote when there are errors (#232 )

Upgraded from v11.1 -> v11.2 (#231 )
Co-authored-by: jackton1 <jackton1@users.noreply.github.com>
2021-10-27 07:30:47 -04:00 · 2021-10-26 12:23:05 -04:00 · 2021-10-26 10:16:42 -04:00 · 2021-10-26 09:41:27 -04:00 · 2021-10-26 09:39:24 -04:00 · 2021-10-26 04:51:01 -04:00
3 changed files with 66 additions and 20 deletions
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,13 +1,46 @@
 # Changelog

-## [v11](https://github.com/tj-actions/changed-files/tree/v11) (2021-10-23)
+## [Unreleased](https://github.com/tj-actions/changed-files/tree/HEAD)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v10.1...v11)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.2...HEAD)
+
+**Fixed bugs:**
+
+- \[BUG\] Changed files not working on self hosted runners [\#227](https://github.com/tj-actions/changed-files/issues/227)
+
+## [v11.2](https://github.com/tj-actions/changed-files/tree/v11.2) (2021-10-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.1...v11.2)

 **Implemented enhancements:**

 - \[Feature\] fetch HEAD without tags [\#220](https://github.com/tj-actions/changed-files/issues/220)

+**Merged pull requests:**
+
+- Resolved bug with already existing remote [\#230](https://github.com/tj-actions/changed-files/pull/230) ([jackton1](https://github.com/jackton1))
+- Revert "bug/fix error with already existing remote" [\#229](https://github.com/tj-actions/changed-files/pull/229) ([jackton1](https://github.com/jackton1))
+- bug/fix error with already existing remote [\#228](https://github.com/tj-actions/changed-files/pull/228) ([jackton1](https://github.com/jackton1))
+- Upgraded to v11.1 [\#226](https://github.com/tj-actions/changed-files/pull/226) ([jackton1](https://github.com/jackton1))
+
+## [v11.1](https://github.com/tj-actions/changed-files/tree/v11.1) (2021-10-25)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11...v11.1)
+
+**Closed issues:**
+
+- \[BUG\] not able to find only python files [\#224](https://github.com/tj-actions/changed-files/issues/224)
+
+**Merged pull requests:**
+
+- Disable automatic tag following [\#225](https://github.com/tj-actions/changed-files/pull/225) ([jackton1](https://github.com/jackton1))
+- Updated README.md [\#223](https://github.com/tj-actions/changed-files/pull/223) ([jackton1](https://github.com/jackton1))
+- Upgraded to v11 [\#222](https://github.com/tj-actions/changed-files/pull/222) ([jackton1](https://github.com/jackton1))
+
+## [v11](https://github.com/tj-actions/changed-files/tree/v11) (2021-10-23)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v10.1...v11)
+
 **Fixed bugs:**

 - \[BUG\] Spaces in file names are not handled correctly [\#216](https://github.com/tj-actions/changed-files/issues/216)
@@ -357,7 +390,7 @@

 ## [v7](https://github.com/tj-actions/changed-files/tree/v7) (2021-06-09)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v7)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v7)

 **Closed issues:**

@@ -373,13 +406,13 @@
 - Update tj-actions/sync-release-version action to v8.7 [\#86](https://github.com/tj-actions/changed-files/pull/86) ([renovate[bot]](https://github.com/apps/renovate))
 - Upgraded to v6.3 [\#85](https://github.com/tj-actions/changed-files/pull/85) ([jackton1](https://github.com/jackton1))

-## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v6)
-
 ## [v6.3](https://github.com/tj-actions/changed-files/tree/v6.3) (2021-05-26)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6.3)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v6.3)
+
+## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6)

 **Merged pull requests:**

--- a/README.md
+++ b/README.md
@@ -59,7 +59,7 @@ jobs:

      - name: Get changed files
        id: changed-files
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2

      - name: List all modified files
        run: |
@@ -121,11 +121,11 @@ jobs:

      - name: Get changed files using defaults
        id: changed-files
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2

      - name: Get changed files using a comma separator
        id: changed-files-comma
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          separator: ","

@@ -147,7 +147,7 @@ jobs:

      - name: Get specific changed files
        id: changed-files-specific
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          files: |
            my-file.txt
@@ -185,14 +185,14 @@ jobs:

      - name: Use a source file or list of file(s) to populate to files input.
        id: changed-files-specific-source-file
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          files_from_source_file: |
            test/changed-files-list.txt

      - name: Use a source file or list of file(s) to populate to files input and optionally specify more files.
        id: changed-files-specific-source-file-and-specify-files
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          files_from_source_file: |
            test/changed-files-list.txt
@@ -201,13 +201,13 @@ jobs:

      - name: Use a different commit SHA
        id: changed-files-custom-sha
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          sha: ${{ github.event.pull_request.head.sha }}

      - name: Use a different base SHA
        id: changed-files-custom-base-sha
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          base_sha: "2096ed0"
          
@@ -219,7 +219,7 @@ jobs:

      - name: Run changed-files with defaults on the dir1
        id: changed-files-for-dir1
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2
        with:
          path: dir1

@@ -241,7 +241,7 @@ jobs:

      - name: Get changed files
        id: changed-files
-        uses: tj-actions/changed-files@v11
+        uses: tj-actions/changed-files@v11.2

      - name: Pre-commit
        uses: pre-commit/action@v2.0.0
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -17,18 +17,29 @@ fi

 SERVER_URL=$(echo "$GITHUB_SERVER_URL" | awk -F/ '{print $3}')

-git remote add temp_changed_files "https://${INPUT_TOKEN}@${SERVER_URL}/${GITHUB_REPOSITORY}"
+echo "Setting up 'temp_changed_files' remote..."
+
+git ls-remote --exit-code temp_changed_files 1>/dev/null 2>&1 && exit_status=$? || exit_status=$?
+
+if [[ $exit_status -ne 0 ]]; then
+  echo "No 'temp_changed_files' remote found"
+  echo "Creating 'temp_changed_files' remote..."
+  git remote add temp_changed_files "https://${INPUT_TOKEN}@${SERVER_URL}/${GITHUB_REPOSITORY}"
+else
+  echo "Found 'temp_changed_files' remote"
+fi

 echo "Getting HEAD info..."

 if [[ -z $INPUT_SHA ]]; then
  CURRENT_SHA=$(git rev-parse HEAD 2>&1) && exit_status=$? || exit_status=$?
 else
-  CURRENT_SHA=$INPUT_SHA
+  CURRENT_SHA=$INPUT_SHA && exit_status=$? || exit_status=$?
 fi

 if [[ $exit_status -ne 0 ]]; then
  echo "::warning::Unable to determine the current head sha"
+  git remote remove temp_changed_files
  exit 1
 fi

@@ -44,6 +55,7 @@ if [[ -z $GITHUB_BASE_REF ]]; then
  if [[ $exit_status -ne 0 ]]; then
    echo "::warning::Unable to determine the previous commit sha"
    echo "::warning::You seem to be missing 'fetch-depth: 0' or 'fetch-depth: 2'. See https://github.com/tj-actions/changed-files#usage"
+    git remote remove temp_changed_files
    exit 1
  fi
 else
@@ -58,6 +70,7 @@ else

  if [[ $exit_status -ne 0 ]]; then
    echo "::warning::Unable to determine the base ref sha for ${TARGET_BRANCH}"
+    git remote remove temp_changed_files
    exit 1
  fi
 fi
Author	SHA1	Message	Date
Tonye Jack	902e607379	[Security]: Prevent persisting the remote when there are errors (#232 )	2021-10-27 07:30:47 -04:00
Tonye Jack	29558f2ca4	Upgraded from v11.1 -> v11.2 (#231 ) Co-authored-by: jackton1 <jackton1@users.noreply.github.com>	2021-10-26 12:23:05 -04:00
Tonye Jack	2b51570d5f	Resolved bug with already existing remote (#230 ) * Resolved bug with already existing remote * Added the --exit-code option * Added debug lines * Update entrypoint.sh * Update entrypoint.sh	2021-10-26 10:16:42 -04:00
Tonye Jack	227fb65ec9	Revert "Resolved bug with already existing remote (#228 )" (#229 ) This reverts commit `3b3a421bef`.	2021-10-26 09:41:27 -04:00
Tonye Jack	3b3a421bef	Resolved bug with already existing remote (#228 )	2021-10-26 09:39:24 -04:00
Tonye Jack	5de15f855c	Upgraded from v11 -> v11.1 (#226 ) Co-authored-by: jackton1 <jackton1@users.noreply.github.com>	2021-10-26 04:51:01 -04:00