fix: bug detecting other deleted and modified (#406)

Co-authored-by: jackton1 <jackton1@users.noreply.github.com>

.github/workflows/submodule-sync.yml

@@ -0,0 +1,28 @@
+on:
+  workflow_dispatch:
+
+jobs:
+  sync:
+    name: Submodule Sync
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+          submodules: recursive
+
+      - name: Git Sumbodule Update
+        run: |
+          git pull --recurse-submodules
+          git submodule update --remote --recursive
+      
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v3.12.1
+        with:
+          title: "Updated submodule"
+          branch: "chore/update-submodule"
+          commit-message: "Updated submodule"
+          body: "Updated submodule"
+          token: ${{ secrets.PAT_TOKEN }}

.github/workflows/sync-release-version.yml

@@ -19,7 +19,7 @@ jobs:
           paths: |
             README.md
       - name: Generate CHANGELOG
-        uses: tj-actions/github-changelog-generator@v1.11
+        uses: tj-actions/github-changelog-generator@v1.12
         with:
           output: 'HISTORY.md'
       - name: Create Pull Request

.github/workflows/test.yml

@@ -35,12 +35,6 @@ jobs:
           submodules: true
           fetch-depth: 0
 
-      - name: Show github context
-        run: |
-          echo '${{ toJSON(github) }}'
-        shell:
-          bash
-
       - name: Get changed files use_fork_point
         id: changed-files-fork-point
         uses: ./

HISTORY.md

@@ -1,5 +1,52 @@
 # Changelog
 
+## [Unreleased](https://github.com/tj-actions/changed-files/tree/HEAD)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17.1...HEAD)
+
+**Fixed bugs:**
+
+- \[BUG\] Gracefully handle errors for repositories without any previous commits [\#365](https://github.com/tj-actions/changed-files/issues/365)
+
+## [v17.1](https://github.com/tj-actions/changed-files/tree/v17.1) (2022-02-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17...v17.1)
+
+**Closed issues:**
+
+- How can I set the action to review all commits since the last workflow run? [\#400](https://github.com/tj-actions/changed-files/issues/400)
+- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
+
+**Merged pull requests:**
+
+- fix: handle errors for repositories without any previous commit history [\#404](https://github.com/tj-actions/changed-files/pull/404) ([jackton1](https://github.com/jackton1))
+- Updated submodule [\#403](https://github.com/tj-actions/changed-files/pull/403) ([jackton1](https://github.com/jackton1))
+- Update tj-actions/github-changelog-generator action to v1.12 [\#402](https://github.com/tj-actions/changed-files/pull/402) ([renovate[bot]](https://github.com/apps/renovate))
+- chore: switch sed for awk [\#401](https://github.com/tj-actions/changed-files/pull/401) ([jackton1](https://github.com/jackton1))
+- Upgraded to v17 [\#399](https://github.com/tj-actions/changed-files/pull/399) ([jackton1](https://github.com/jackton1))
+
+## [v17](https://github.com/tj-actions/changed-files/tree/v17) (2022-02-23)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v16...v17)
+
+**Implemented enhancements:**
+
+- \[Feature\] Add support for detecting changes in submodules [\#349](https://github.com/tj-actions/changed-files/issues/349)
+
+**Fixed bugs:**
+
+- \[BUG\] It looks like no value such as any\_changed has been written. [\#393](https://github.com/tj-actions/changed-files/issues/393)
+
+**Merged pull requests:**
+
+- Updated README.md [\#398](https://github.com/tj-actions/changed-files/pull/398) ([jackton1](https://github.com/jackton1))
+- docs: add pkit as a contributor for code [\#397](https://github.com/tj-actions/changed-files/pull/397) ([allcontributors[bot]](https://github.com/apps/allcontributors))
+- feat: Add support for detecting submodules changes [\#394](https://github.com/tj-actions/changed-files/pull/394) ([pkit](https://github.com/pkit))
+- Updated README.md [\#392](https://github.com/tj-actions/changed-files/pull/392) ([jackton1](https://github.com/jackton1))
+- docs: add fagai as a contributor for doc [\#391](https://github.com/tj-actions/changed-files/pull/391) ([allcontributors[bot]](https://github.com/apps/allcontributors))
+- fix README [\#390](https://github.com/tj-actions/changed-files/pull/390) ([fagai](https://github.com/fagai))
+- Upgraded to v16 [\#389](https://github.com/tj-actions/changed-files/pull/389) ([jackton1](https://github.com/jackton1))
+
 ## [v16](https://github.com/tj-actions/changed-files/tree/v16) (2022-02-18)
 
 [Full Changelog](https://github.com/tj-actions/changed-files/compare/v15...v16)
@@ -220,10 +267,6 @@
 - \[BUG\] wrong result of any\_change output [\#314](https://github.com/tj-actions/changed-files/issues/314)
 - \[BUG\] Investigate possible bug using since\_last\_remote\_commit when force pushing changes. [\#303](https://github.com/tj-actions/changed-files/issues/303)
 
-**Closed issues:**
-
-- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
-
 ## [v12.2](https://github.com/tj-actions/changed-files/tree/v12.2) (2021-12-30)
 
 [Full Changelog](https://github.com/tj-actions/changed-files/compare/v2.0.1...v12.2)

README.md

@@ -20,7 +20,7 @@ Retrieve all changed files relative to the target branch (`pull_request*` based
 *   Fast execution (0-2 seconds on average).
 *   Easy to debug.
 *   Boolean output indicating that certain files have been changed.
-*   Git submodules
+*   Git submodules support.
 *   Multiple repositories support.
 *   [GitHub-hosted runners](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners) support
 *   [GitHub Enterprise Server](https://docs.github.com/en/enterprise-server@3.3/admin/github-actions/getting-started-with-github-actions-for-your-enterprise/getting-started-with-github-actions-for-github-enterprise-server) support.
@@ -67,7 +67,7 @@ jobs:
 
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
 
       - name: List all changed files
         run: |
@@ -146,14 +146,17 @@ Support this project with a :star:
 ...
     steps:
       - uses: actions/checkout@v2
+#        with:
+#          fetch-depth: 0  # OR "2" -> To retrieve the preceding commit.
+#          submodules: true # OR "recursive" -> To include all changed submodule files.
 
       - name: Get changed files using defaults
         id: changed-files
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
 
       - name: Get changed files using a comma separator
         id: changed-files-comma
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           separator: ","
 
@@ -175,7 +178,7 @@ Support this project with a :star:
 
       - name: Get specific changed files
         id: changed-files-specific
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           files: |
             my-file.txt
@@ -216,14 +219,14 @@ Support this project with a :star:
 
       - name: Use a source file or list of file(s) to populate to files input.
         id: changed-files-specific-source-file
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           files_from_source_file: |
             test/changed-files-list.txt
 
       - name: Use a source file or list of file(s) to populate to files input and optionally specify more files.
         id: changed-files-specific-source-file-and-specify-files
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           files_from_source_file: |
             test/changed-files-list.txt
@@ -232,13 +235,13 @@ Support this project with a :star:
 
       - name: Use a different commit SHA
         id: changed-files-custom-sha
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           sha: ${{ github.event.pull_request.head.sha }}
 
       - name: Use a different base SHA
         id: changed-files-custom-base-sha
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           base_sha: "2096ed0"
           
@@ -250,7 +253,7 @@ Support this project with a :star:
 
       - name: Run changed-files with defaults on the dir1
         id: changed-files-for-dir1
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           path: dir1
 
@@ -262,13 +265,13 @@ Support this project with a :star:
 
       - name: Run changed-files using the last commit on the remote branch
         id: changed-files-since-last-remote-commit
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           since_last_remote_commit: "true"
       
       - name: Run changed-files using the fork point of a pull request
         id: changed-files-fork-point
-        uses: tj-actions/changed-files@v16
+        uses: tj-actions/changed-files@v17.1
         with:
           use_fork_point: "true"
 

diff-sha.sh

@@ -52,7 +52,11 @@ if [[ -z $GITHUB_BASE_REF ]]; then
   CURRENT_BRANCH=$TARGET_BRANCH
 
   if [[ -z $INPUT_BASE_SHA ]]; then
-    PREVIOUS_SHA=$(git rev-list --no-merges -n 1 HEAD^1 2>&1) && exit_status=$? || exit_status=$?
+    if [[ $(git rev-list --count HEAD) -gt 1 ]]; then
+      PREVIOUS_SHA=$(git rev-list --no-merges -n 1 HEAD^1 2>&1) && exit_status=$? || exit_status=$?
+    else
+      PREVIOUS_SHA=$CURRENT_SHA
+    fi
   else
     PREVIOUS_SHA=$INPUT_BASE_SHA && exit_status=$? || exit_status=$?
     TARGET_BRANCH=$(git name-rev --name-only "$PREVIOUS_SHA" 2>&1) && exit_status=$? || exit_status=$?

entrypoint.sh

@@ -7,13 +7,13 @@ function get_diff() {
   sha="$2"
   filter="$3"
   while IFS='' read -r sub; do
-    sub_commit_pre="$(git diff "$base" "$sha" -- "$sub" | grep '^[-]Subproject commit' | sed 's/[-]Subproject commit //')"
-    sub_commit_cur="$(git diff "$base" "$sha" -- "$sub" | grep '^[+]Subproject commit' | sed 's/[+]Subproject commit //')"
+    sub_commit_pre="$(git diff "$base" "$sha" -- "$sub" | grep '^[-]Subproject commit' | awk '{print $3}')"
+    sub_commit_cur="$(git diff "$base" "$sha" -- "$sub" | grep '^[+]Subproject commit' | awk '{print $3}')"
     if [ -n "$sub_commit_cur" ]; then
     (
       cd "$sub" && (
         # the strange magic number is a hardcoded "empty tree" commit sha
-        get_diff "${sub_commit_pre:-4b825dc642cb6eb9a060e54bf8d69288fbee4904}" "${sub_commit_cur}" "$filter" | sed "s#^#$sub/#"
+        get_diff "${sub_commit_pre:-4b825dc642cb6eb9a060e54bf8d69288fbee4904}" "${sub_commit_cur}" "$filter" | awk -v r="$sub" '{ print "" r "/" $0}'
       )
     )
     fi
@@ -96,7 +96,7 @@ else
     echo "::set-output name=only_changed::true"
   fi
 
-  ALL_OTHER_MODIFIED=$(git diff --diff-filter="ACMRD" --name-only "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
+  ALL_OTHER_MODIFIED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" "ACMRD" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
   UNIQUE_ALL_MODIFIED=$(echo "${ALL_MODIFIED}" | awk '{gsub(/\|/,"\n"); print $0;}' | awk '!a[$0]++' | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
 
   if [[ -n "${UNIQUE_ALL_MODIFIED}" ]]; then
@@ -126,7 +126,7 @@ else
     echo "::set-output name=only_modified::true"
   fi
 
-  ALL_OTHER_DELETED=$(git diff --diff-filter=D --name-only "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
+  ALL_OTHER_DELETED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" D | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
   UNIQUE_ALL_DELETED=$(echo "${DELETED}" | awk '{gsub(/\|/,"\n"); print $0;}' | awk '!a[$0]++' | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
 
   if [[ -n "${UNIQUE_ALL_DELETED}" ]]; then