fix: bug using newline separator (#418 )

Revert "chore: test pull_requests events" (#416 )
chore: test pull_requests events (#415 )
2022-03-08 06:59:26 -05:00 · 2022-03-04 04:35:19 -05:00 · 2022-03-04 04:22:46 -05:00 · 2022-03-03 13:01:09 -05:00 · 2022-03-01 21:59:15 -05:00 · 2022-03-01 21:58:31 -05:00
9 changed files with 100 additions and 47 deletions
--- a/.github/workflows/codacy-analysis.yml
+++ b/.github/workflows/codacy-analysis.yml
@@ -24,11 +24,11 @@ jobs:
    steps:
      # Checkout the repository to the GitHub Actions runner
      - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis
      - name: Run Codacy Analysis CLI
-        uses: codacy/codacy-analysis-cli-action@4.0.0
+        uses: codacy/codacy-analysis-cli-action@4.0.1
        with:
          # Check https://github.com/codacy/codacy-analysis-cli#project-token to get your project token from your Codacy repository
          # You can also omit the token and run the tools that support default configurations
--- a/.github/workflows/rebase.yml
+++ b/.github/workflows/rebase.yml
@@ -8,7 +8,7 @@ jobs:
    if: github.event.issue.pull_request != '' && contains(github.event.comment.body, '/rebase')
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v2.4.0
+      - uses: actions/checkout@v3.0.0
        with:
          token: ${{ secrets.PAT_TOKEN }}
          fetch-depth: 0 # otherwise, you will failed to push refs to dest repo
--- a/.github/workflows/submodule-sync.yml
+++ b/.github/workflows/submodule-sync.yml
@@ -8,7 +8,7 @@ jobs:

    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          fetch-depth: 0
          submodules: recursive
@@ -19,7 +19,7 @@ jobs:
          git submodule update --remote --recursive
      
      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3.12.1
+        uses: peter-evans/create-pull-request@v3.14.0
        with:
          title: "Updated submodule"
          branch: "chore/update-submodule"
--- a/.github/workflows/sync-release-version.yml
+++ b/.github/workflows/sync-release-version.yml
@@ -8,7 +8,7 @@ jobs:
  update-version:
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v2.4.0
+      - uses: actions/checkout@v3.0.0
        with:
          fetch-depth: 0
      - name: Sync release version.
@@ -23,7 +23,7 @@ jobs:
        with:
          output: 'HISTORY.md'
      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3.12.1
+        uses: peter-evans/create-pull-request@v3.14.0
        with:
          base: "main"
          title: "Upgraded to ${{ steps.sync-release-version.outputs.new_version }}"
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -16,7 +16,7 @@ jobs:

    steps:
      - name: Checkout to branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
      - name: shellcheck
        uses: reviewdog/action-shellcheck@v1.14
  
@@ -30,7 +30,7 @@ jobs:

    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true
          fetch-depth: 0
@@ -68,7 +68,7 @@ jobs:
        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
    steps:
      - name: Checkout into dir1
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true
          fetch-depth: 0
@@ -91,7 +91,7 @@ jobs:
        shell:
          bash
      - name: Checkout into dir2
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true
          fetch-depth: 0
@@ -124,7 +124,7 @@ jobs:

    steps:
      - name: Checkout to branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Run changed-files with non existent base sha
        id: changed-files
@@ -163,7 +163,7 @@ jobs:

    steps:
      - name: Checkout to branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Run changed-files with non existent sha
        id: changed-files
@@ -202,7 +202,7 @@ jobs:

    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          submodules: true
          fetch-depth: 0
@@ -237,6 +237,16 @@ jobs:
          echo '${{ toJSON(steps.changed-files-forward-slash.outputs) }}'
        shell:
          bash
+      - name: Run changed-files with newline separator
+        id: changed-files-newline
+        uses: ./
+        with:
+          separator: "\n"
+      - name: Show output
+        run: |
+          echo '${{ toJSON(steps.changed-files-newline.outputs) }}'
+        shell:
+          bash
      - name: Run changed-files with pipe separator
        id: changed-files-pipe
        uses: ./
@@ -257,6 +267,18 @@ jobs:
          echo '${{ toJSON(steps.changed-files-comma.outputs) }}'
        shell:
          bash
+      - name: Run changed-files with specific files from a source file using a newline separator
+        id: changed-files-specific-newline-source-file
+        uses: ./
+        with:
+          files_from_source_file: |
+            test/changed-files-list.txt
+          separator: "\n"
+      - name: Show output
+        run: |
+          echo '${{ toJSON(steps.changed-files-specific-newline-source-file.outputs) }}'
+        shell:
+          bash
      - name: Run changed-files with specific files
        id: changed-files-specific
        uses: ./
--- a/.github/workflows/update-readme.yml
+++ b/.github/workflows/update-readme.yml
@@ -9,7 +9,7 @@ jobs:
  sync-assets:
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@v2.4.0
+      - uses: actions/checkout@v3.0.0
        with:
          fetch-depth: 0

@@ -31,7 +31,7 @@ jobs:

      - name: Create Pull Request
        if: failure()
-        uses: peter-evans/create-pull-request@v3.12.1
+        uses: peter-evans/create-pull-request@v3.14.0
        with:
          base: "main"
          title: "Updated README.md"
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,5 +1,35 @@
 # Changelog

+## [v17.2](https://github.com/tj-actions/changed-files/tree/v17.2) (2022-02-27)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17.1...v17.2)
+
+**Fixed bugs:**
+
+- \[BUG\] Gracefully handle errors for repositories without any previous commits [\#365](https://github.com/tj-actions/changed-files/issues/365)
+
+**Merged pull requests:**
+
+- fix: bug detecting other deleted and modified [\#406](https://github.com/tj-actions/changed-files/pull/406) ([jackton1](https://github.com/jackton1))
+- Upgraded to v17.1 [\#405](https://github.com/tj-actions/changed-files/pull/405) ([jackton1](https://github.com/jackton1))
+
+## [v17.1](https://github.com/tj-actions/changed-files/tree/v17.1) (2022-02-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17...v17.1)
+
+**Closed issues:**
+
+- How can I set the action to review all commits since the last workflow run? [\#400](https://github.com/tj-actions/changed-files/issues/400)
+- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
+
+**Merged pull requests:**
+
+- fix: handle errors for repositories without any previous commit history [\#404](https://github.com/tj-actions/changed-files/pull/404) ([jackton1](https://github.com/jackton1))
+- Updated submodule [\#403](https://github.com/tj-actions/changed-files/pull/403) ([jackton1](https://github.com/jackton1))
+- Update tj-actions/github-changelog-generator action to v1.12 [\#402](https://github.com/tj-actions/changed-files/pull/402) ([renovate[bot]](https://github.com/apps/renovate))
+- chore: switch sed for awk [\#401](https://github.com/tj-actions/changed-files/pull/401) ([jackton1](https://github.com/jackton1))
+- Upgraded to v17 [\#399](https://github.com/tj-actions/changed-files/pull/399) ([jackton1](https://github.com/jackton1))
+
 ## [v17](https://github.com/tj-actions/changed-files/tree/v17) (2022-02-23)

 [Full Changelog](https://github.com/tj-actions/changed-files/compare/v16...v17)
@@ -242,10 +272,6 @@
 - \[BUG\] wrong result of any\_change output [\#314](https://github.com/tj-actions/changed-files/issues/314)
 - \[BUG\] Investigate possible bug using since\_last\_remote\_commit when force pushing changes. [\#303](https://github.com/tj-actions/changed-files/issues/303)

-**Closed issues:**
-
- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
-
 ## [v2.0.1](https://github.com/tj-actions/changed-files/tree/v2.0.1) (2021-12-30)

 [Full Changelog](https://github.com/tj-actions/changed-files/compare/v12.2...v2.0.1)
@@ -402,7 +428,7 @@

 ## [v1.2.1](https://github.com/tj-actions/changed-files/tree/v1.2.1) (2021-11-08)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.5...v1.2.1)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v1.2.0...v1.2.1)

 **Implemented enhancements:**

@@ -416,13 +442,13 @@
 - Update actions/checkout action to v2.4.0 [\#243](https://github.com/tj-actions/changed-files/pull/243) ([renovate[bot]](https://github.com/apps/renovate))
 - Upgraded to v11.5 [\#241](https://github.com/tj-actions/changed-files/pull/241) ([jackton1](https://github.com/jackton1))

-## [v11.5](https://github.com/tj-actions/changed-files/tree/v11.5) (2021-10-30)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v1.2.0...v11.5)
-
 ## [v1.2.0](https://github.com/tj-actions/changed-files/tree/v1.2.0) (2021-10-30)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.4...v1.2.0)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.5...v1.2.0)
+
+## [v11.5](https://github.com/tj-actions/changed-files/tree/v11.5) (2021-10-30)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v11.4...v11.5)

 **Merged pull requests:**

@@ -815,7 +841,7 @@

 ## [v7](https://github.com/tj-actions/changed-files/tree/v7) (2021-06-09)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v7)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v7)

 **Closed issues:**

@@ -831,13 +857,13 @@
 - Update tj-actions/sync-release-version action to v8.7 [\#86](https://github.com/tj-actions/changed-files/pull/86) ([renovate[bot]](https://github.com/apps/renovate))
 - Upgraded to v6.3 [\#85](https://github.com/tj-actions/changed-files/pull/85) ([jackton1](https://github.com/jackton1))

-## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v6)
-
 ## [v6.3](https://github.com/tj-actions/changed-files/tree/v6.3) (2021-05-26)

-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6.3)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v6.3)
+
+## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6)

 **Merged pull requests:**

--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ jobs:

      - name: Get changed files
        id: changed-files
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2

      - name: List all changed files
        run: |
@@ -137,8 +137,8 @@ Support this project with a :star:
 |                sha                |        `string`        |  `true`  |  `${{ github.sha }}`  |                                                                                                                           Specify a different <br> commit SHA <br> used for <br> comparing changes                                                                                                                            |
 |             base\_sha             |        `string`        | `false`  |                       |                                                                                                                         Specify a different <br> base commit SHA <br> used for <br> comparing changes                                                                                                                         |
 |               path                |        `string`        | `false`  |                       |                                                                                                                              Relative path under <br> `GITHUB_WORKSPACE` <br> to the repository                                                                                                                               |
-|    since\_last\_remote\_commit    |        `string`        | `false`  |        `false`        |                                                                 Use the last commit on the remote <br> branch as the `base_sha` <br> (Defaults to the previous commit). <br /> NOTE: This requires <br /> `fetch-depth: 0` <br /> with `actions/checkout@v2`                                                                  |
-|          use\_fork\_point           |        `string`        | `false`  |        `false`        |             Finds best common ancestor <br /> between two commits <br /> to use in a three-way merge <br /> as the `base_sha` <br /> See: [git merge-base](https://git-scm.com/docs/git-merge-base#Documentation/git-merge-base.txt---fork-point). NOTE: This pulls the entire commit history of the base branch              |
+|    since\_last\_remote\_commit    |        `string`        | `false`  |        `false`        |                                                                 Use the last commit on the remote <br> branch as the `base_sha` <br> (Defaults to the last commit <br> on the target branch for Pull requests <br> or the previous commit <br> on the current branch <br> for push events). <br /> NOTE: This requires <br /> `fetch-depth: 0` <br /> with `actions/checkout@v2`                                                                  |
+|          use\_fork\_point           |        `string`        | `false`  |        `false`        |             Finds best common ancestor <br /> between two commits <br /> to use in a three-way merge <br /> as the `base_sha` <br /> See: [git merge-base](https://git-scm.com/docs/git-merge-base#Documentation/git-merge-base.txt---fork-point). <br> NOTE: This pulls the entire commit history of the base branch              |

 ## Example

@@ -152,11 +152,11 @@ Support this project with a :star:

      - name: Get changed files using defaults
        id: changed-files
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2

      - name: Get changed files using a comma separator
        id: changed-files-comma
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          separator: ","

@@ -178,7 +178,7 @@ Support this project with a :star:

      - name: Get specific changed files
        id: changed-files-specific
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          files: |
            my-file.txt
@@ -219,14 +219,14 @@ Support this project with a :star:

      - name: Use a source file or list of file(s) to populate to files input.
        id: changed-files-specific-source-file
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          files_from_source_file: |
            test/changed-files-list.txt

      - name: Use a source file or list of file(s) to populate to files input and optionally specify more files.
        id: changed-files-specific-source-file-and-specify-files
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          files_from_source_file: |
            test/changed-files-list.txt
@@ -235,13 +235,13 @@ Support this project with a :star:

      - name: Use a different commit SHA
        id: changed-files-custom-sha
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          sha: ${{ github.event.pull_request.head.sha }}

      - name: Use a different base SHA
        id: changed-files-custom-base-sha
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          base_sha: "2096ed0"
          
@@ -253,7 +253,7 @@ Support this project with a :star:

      - name: Run changed-files with defaults on the dir1
        id: changed-files-for-dir1
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          path: dir1

@@ -265,13 +265,13 @@ Support this project with a :star:

      - name: Run changed-files using the last commit on the remote branch
        id: changed-files-since-last-remote-commit
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          since_last_remote_commit: "true"
      
      - name: Run changed-files using the fork point of a pull request
        id: changed-files-fork-point
-        uses: tj-actions/changed-files@v17
+        uses: tj-actions/changed-files@v17.2
        with:
          use_fork_point: "true"

@@ -285,6 +285,7 @@ Support this project with a :star:

 > NOTE: :warning:
 >
+> *   Using characters like `\n`, `%` and `\r` as separators would be [URL encoded](https://www.w3schools.com/tags/ref_urlencode.asp)
 > *   Spaces in file names can introduce bugs when using bash loops. See: [#216](https://github.com/tj-actions/changed-files/issues/216)
 > *   However, this action will handle spaces in file names, with a recommendation of using a separator to prevent hidden issues.
 >     ![Screen Shot 2021-10-23 at 9 37 34 AM](https://user-images.githubusercontent.com/17484350/138558767-b13c90bf-a1ae-4e86-9520-70a6a4624f41.png)
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -2,6 +2,10 @@

 set -eu

+INPUT_SEPARATOR="${INPUT_SEPARATOR//'%'/'%25'}"
+INPUT_SEPARATOR="${INPUT_SEPARATOR//$'\n'/'%0A'}"
+INPUT_SEPARATOR="${INPUT_SEPARATOR//$'\r'/'%0D'}"
+
 function get_diff() {
  base="$1"
  sha="$2"
@@ -96,7 +100,7 @@ else
    echo "::set-output name=only_changed::true"
  fi

-  ALL_OTHER_MODIFIED=$(git diff --diff-filter="ACMRD" --name-only "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
+  ALL_OTHER_MODIFIED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" "ACMRD" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
  UNIQUE_ALL_MODIFIED=$(echo "${ALL_MODIFIED}" | awk '{gsub(/\|/,"\n"); print $0;}' | awk '!a[$0]++' | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')

  if [[ -n "${UNIQUE_ALL_MODIFIED}" ]]; then
@@ -126,7 +130,7 @@ else
    echo "::set-output name=only_modified::true"
  fi

-  ALL_OTHER_DELETED=$(git diff --diff-filter=D --name-only "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
+  ALL_OTHER_DELETED=$(get_diff "$INPUT_PREVIOUS_SHA" "$INPUT_CURRENT_SHA" D | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')
  UNIQUE_ALL_DELETED=$(echo "${DELETED}" | awk '{gsub(/\|/,"\n"); print $0;}' | awk '!a[$0]++' | awk -v d="|" '{s=(NR==1?s:s d)$0}END{print s}')

  if [[ -n "${UNIQUE_ALL_DELETED}" ]]; then
Author	SHA1	Message	Date
Tonye Jack	f5a8de7d36	fix: bug using newline separator (#418 )	2022-03-08 06:59:26 -05:00
Tonye Jack	abb8062519	Revert "chore: test pull_requests events" (#416 )	2022-03-04 04:35:19 -05:00
Tonye Jack	2702dd241c	chore: test pull_requests events (#415 )	2022-03-04 04:22:46 -05:00
Renovate Bot	c7b6b5068a	Update codacy/codacy-analysis-cli-action action to v4.0.1	2022-03-03 13:01:09 -05:00
Tonye Jack	32778b637f	Update README.md	2022-03-01 21:59:15 -05:00
Tonye Jack	eeb5dfb252	Update README.md	2022-03-01 21:58:31 -05:00
Renovate Bot	44a759c065	Update actions/checkout action	2022-03-01 14:57:43 -05:00
Renovate Bot	a2a827260c	Update peter-evans/create-pull-request action to v3.14.0	2022-03-01 00:35:51 +00:00
Renovate Bot	a8daea7bf1	Update peter-evans/create-pull-request action to v3.13.0	2022-02-28 04:31:33 -05:00
Tonye Jack	53dd0e017f	Upgraded from v17.1 -> v17.2 (#407 )	2022-02-27 13:00:01 -05:00
Tonye Jack	0bc7d4006f	fix: bug detecting other deleted and modified (#406 )	2022-02-27 12:47:28 -05:00
Tonye Jack	b224e37625	Upgraded from v17 -> v17.1 (#405 ) Co-authored-by: jackton1 <jackton1@users.noreply.github.com>	2022-02-26 09:53:14 -05:00