fix: bug passing invalid patterns to grep (#453)

Co-authored-by: jackton1 <jackton1@users.noreply.github.com>

.github/workflows/auto-merge.yml

@@ -16,7 +16,7 @@ jobs:
       github.actor == 'renovate'
     steps:
       - name: automerge
-        uses: pascalgn/automerge-action@v0.14.3
+        uses: pascalgn/automerge-action@v0.15.2
         env:
           GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
           MERGE_METHOD: "rebase"

.github/workflows/submodule-sync.yml

@@ -19,7 +19,7 @@ jobs:
           git submodule update --remote --recursive
       
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3.14.0
+        uses: peter-evans/create-pull-request@v4.0.0
         with:
           title: "Updated submodule"
           branch: "chore/update-submodule"

.github/workflows/sync-release-version.yml

@@ -19,11 +19,11 @@ jobs:
           paths: |
             README.md
       - name: Generate CHANGELOG
-        uses: tj-actions/github-changelog-generator@v1.12
+        uses: tj-actions/github-changelog-generator@v1.13
         with:
           output: 'HISTORY.md'
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3.14.0
+        uses: peter-evans/create-pull-request@v4.0.0
         with:
           base: "main"
           title: "Upgraded to ${{ steps.sync-release-version.outputs.new_version }}"

.github/workflows/test.yml

@@ -25,8 +25,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
+      max-parallel: 4
       matrix:
-        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
+        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022]
 
     steps:
       - name: Checkout
@@ -64,8 +65,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
+      max-parallel: 4
       matrix:
-        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
+        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022]
     steps:
       - name: Checkout into dir1
         uses: actions/checkout@v3
@@ -119,8 +121,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
+      max-parallel: 4
       matrix:
-        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
+        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022]
 
     steps:
       - name: Checkout to branch
@@ -158,8 +161,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
+      max-parallel: 4
       matrix:
-        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
+        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022]
 
     steps:
       - name: Checkout to branch
@@ -197,8 +201,9 @@ jobs:
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
+      max-parallel: 4
       matrix:
-        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022, windows-2016]
+        platform: [ubuntu-latest, windows-latest, macos-latest, macos-11, ubuntu-18.04, windows-2022]
 
     steps:
       - name: Checkout

.github/workflows/update-readme.yml

@@ -14,7 +14,7 @@ jobs:
           fetch-depth: 0
 
       - name: Run test
-        uses: tj-actions/remark@v2.3
+        uses: tj-actions/remark@v3
 
       - name: Verify Changed files
         uses: tj-actions/verify-changed-files@v9
@@ -31,7 +31,7 @@ jobs:
 
       - name: Create Pull Request
         if: failure()
-        uses: peter-evans/create-pull-request@v3.14.0
+        uses: peter-evans/create-pull-request@v4.0.0
         with:
           base: "main"
           title: "Updated README.md"

HISTORY.md

@@ -1,12 +1,72 @@
 # Changelog
 
-## [Unreleased](https://github.com/tj-actions/changed-files/tree/HEAD)
+## [v18.4](https://github.com/tj-actions/changed-files/tree/v18.4) (2022-03-21)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17.3...HEAD)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v18.3...v18.4)
+
+**Closed issues:**
+
+- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
+
+**Merged pull requests:**
+
+- Bump tj-actions/remark from 2.3 to 3 [\#442](https://github.com/tj-actions/changed-files/pull/442) ([dependabot[bot]](https://github.com/apps/dependabot))
+- chore\(deps\): update tj-actions/glob action to v7.10 [\#440](https://github.com/tj-actions/changed-files/pull/440) ([renovate[bot]](https://github.com/apps/renovate))
+- Update README.md [\#439](https://github.com/tj-actions/changed-files/pull/439) ([jackton1](https://github.com/jackton1))
+- Upgraded to v18.3 [\#438](https://github.com/tj-actions/changed-files/pull/438) ([jackton1](https://github.com/jackton1))
+
+## [v18.3](https://github.com/tj-actions/changed-files/tree/v18.3) (2022-03-16)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v18.2...v18.3)
+
+**Merged pull requests:**
+
+- chore\(deps\): update tj-actions/glob action to v7.9 [\#436](https://github.com/tj-actions/changed-files/pull/436) ([renovate[bot]](https://github.com/apps/renovate))
+- Upgraded to v18.2 [\#435](https://github.com/tj-actions/changed-files/pull/435) ([jackton1](https://github.com/jackton1))
+
+## [v18.2](https://github.com/tj-actions/changed-files/tree/v18.2) (2022-03-16)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v18.1...v18.2)
+
+**Fixed bugs:**
+
+- \[BUG\] Glob Pattern Incorrect? [\#433](https://github.com/tj-actions/changed-files/issues/433)
+- \[BUG\] Providing files\_ignore without using files input doesn't exclude ignored files [\#429](https://github.com/tj-actions/changed-files/issues/429)
+
+**Merged pull requests:**
+
+- fix: bug omitting the fetch-depth for push based events [\#434](https://github.com/tj-actions/changed-files/pull/434) ([jackton1](https://github.com/jackton1))
+- Upgraded to v18.1 [\#432](https://github.com/tj-actions/changed-files/pull/432) ([jackton1](https://github.com/jackton1))
+
+## [v18.1](https://github.com/tj-actions/changed-files/tree/v18.1) (2022-03-14)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v18...v18.1)
+
+**Merged pull requests:**
+
+- fix: bug providing files\_ignore without files input [\#431](https://github.com/tj-actions/changed-files/pull/431) ([jackton1](https://github.com/jackton1))
+- chore\(deps\): update tj-actions/glob action to v7.7 [\#430](https://github.com/tj-actions/changed-files/pull/430) ([renovate[bot]](https://github.com/apps/renovate))
+- chore\(deps\): update tj-actions/glob action to v7.6 [\#428](https://github.com/tj-actions/changed-files/pull/428) ([renovate[bot]](https://github.com/apps/renovate))
+- chore\(deps\): update tj-actions/github-changelog-generator action to v1.13 [\#427](https://github.com/tj-actions/changed-files/pull/427) ([renovate[bot]](https://github.com/apps/renovate))
+- Upgraded to v18 [\#426](https://github.com/tj-actions/changed-files/pull/426) ([jackton1](https://github.com/jackton1))
+
+## [v18](https://github.com/tj-actions/changed-files/tree/v18) (2022-03-14)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v17.3...v18)
 
 **Fixed bugs:**
 
 - \[BUG\] Separator `\n` only outputs first changed file [\#417](https://github.com/tj-actions/changed-files/issues/417)
+- \[BUG\] Argument list too long with files input [\#367](https://github.com/tj-actions/changed-files/issues/367)
+
+**Merged pull requests:**
+
+- feat: Add support for using file patterns on disk [\#425](https://github.com/tj-actions/changed-files/pull/425) ([jackton1](https://github.com/jackton1))
+- chore\(deps\): update tj-actions/glob action to v7.5 [\#424](https://github.com/tj-actions/changed-files/pull/424) ([renovate[bot]](https://github.com/apps/renovate))
+- Update tj-actions/verify-changed-files action to v9 [\#423](https://github.com/tj-actions/changed-files/pull/423) ([renovate[bot]](https://github.com/apps/renovate))
+- chore: Upgrade tj-actions/glob to v7.4 [\#422](https://github.com/tj-actions/changed-files/pull/422) ([jackton1](https://github.com/jackton1))
+- Update codacy/codacy-analysis-cli-action action to v4.0.2 [\#421](https://github.com/tj-actions/changed-files/pull/421) ([renovate[bot]](https://github.com/apps/renovate))
+- Upgraded to v17.3 [\#420](https://github.com/tj-actions/changed-files/pull/420) ([jackton1](https://github.com/jackton1))
 
 ## [v17.3](https://github.com/tj-actions/changed-files/tree/v17.3) (2022-03-08)
 
@@ -21,7 +81,6 @@
 **Closed issues:**
 
 - \[BUG\] Unexpected result [\#412](https://github.com/tj-actions/changed-files/issues/412)
-- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
 
 **Merged pull requests:**
 
@@ -285,7 +344,7 @@
 
 ## [v13](https://github.com/tj-actions/changed-files/tree/v13) (2022-02-17)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v12.2...v13)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v2.0.1...v13)
 
 **Implemented enhancements:**
 
@@ -304,13 +363,13 @@
 - \[BUG\] wrong result of any\_change output [\#314](https://github.com/tj-actions/changed-files/issues/314)
 - \[BUG\] Investigate possible bug using since\_last\_remote\_commit when force pushing changes. [\#303](https://github.com/tj-actions/changed-files/issues/303)
 
-## [v12.2](https://github.com/tj-actions/changed-files/tree/v12.2) (2021-12-30)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v2.0.1...v12.2)
-
 ## [v2.0.1](https://github.com/tj-actions/changed-files/tree/v2.0.1) (2021-12-30)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v12.1...v2.0.1)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v12.2...v2.0.1)
+
+## [v12.2](https://github.com/tj-actions/changed-files/tree/v12.2) (2021-12-30)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v12.1...v12.2)
 
 **Merged pull requests:**
 

README.md

@@ -20,7 +20,7 @@ Retrieve all changed files relative to the target branch (`pull_request*` based
 *   Fast execution (0-2 seconds on average).
 *   Easy to debug.
 *   Boolean output indicating that certain files have been changed.
-*   Large repository support.
+*   Scales to large repositories.
 *   Git submodules support.
 *   Multiple repositories support.
 *   [GitHub-hosted runners](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners) support
@@ -44,7 +44,7 @@ Retrieve all changed files relative to the target branch (`pull_request*` based
 > *   **IMPORTANT:** For `push` events you need to include `fetch-depth: 0` **OR** `fetch-depth: 2` depending on your use case.
 > *   When using `persist-credentials: false` with `actions/checkout@v2` you'll need to specify a `token` using the `token` input.
 > *   For monorepos where pulling all the branch history might not be desired, you can omit `fetch-depth` for `pull_request` events.
-> *   For files located in a sub-directory ensure that the pattern specified contains `**` (globstar) to match any preceding directories or explicitly pass the full path relative to the project root. See: [#314](https://github.com/tj-actions/changed-files/issues/314)
+> *   For files located in a sub-directory ensure that the pattern specified contains `**/` (globstar) to match any preceding directories or explicitly pass the full path relative to the project root. See: [#314](https://github.com/tj-actions/changed-files/issues/314)
 
 ```yaml
 name: CI
@@ -68,7 +68,7 @@ jobs:
 
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
 
       - name: List all changed files
         run: |
@@ -153,11 +153,11 @@ Support this project with a :star:
 
       - name: Get changed files using defaults
         id: changed-files
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
 
       - name: Get changed files using a comma separator
         id: changed-files-comma
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           separator: ","
 
@@ -179,7 +179,7 @@ Support this project with a :star:
 
       - name: Get specific changed files
         id: changed-files-specific
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           files: |
             my-file.txt
@@ -220,14 +220,14 @@ Support this project with a :star:
 
       - name: Use a source file or list of file(s) to populate to files input.
         id: changed-files-specific-source-file
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           files_from_source_file: |
             test/changed-files-list.txt
 
       - name: Use a source file or list of file(s) to populate to files input and optionally specify more files.
         id: changed-files-specific-source-file-and-specify-files
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           files_from_source_file: |
             test/changed-files-list.txt
@@ -236,13 +236,13 @@ Support this project with a :star:
 
       - name: Use a different commit SHA
         id: changed-files-custom-sha
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           sha: ${{ github.event.pull_request.head.sha }}
 
       - name: Use a different base SHA
         id: changed-files-custom-base-sha
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           base_sha: "2096ed0"
           
@@ -254,7 +254,7 @@ Support this project with a :star:
 
       - name: Run changed-files with defaults on the dir1
         id: changed-files-for-dir1
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           path: dir1
 
@@ -266,13 +266,13 @@ Support this project with a :star:
 
       - name: Run changed-files using the last commit on the remote branch
         id: changed-files-since-last-remote-commit
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           since_last_remote_commit: "true"
       
       - name: Run changed-files using the fork point of a pull request
         id: changed-files-fork-point
-        uses: tj-actions/changed-files@v17.3
+        uses: tj-actions/changed-files@v18.4
         with:
           use_fork_point: "true"
 
@@ -300,6 +300,42 @@ This project follows a `v(major).(patch)` versioning scheme with the exception o
 > *   Users referencing the legacy `v1.x.x` -> `v5.0.0` semantic versions, are required to switch over to `v10.x` -> `v15.x` respectively as new releases would no longer be deployed using the old versioning scheme.
 > *   A breaking change was introduced in `v1.1.4` and `v13.x` which has been fixed.
 
+## Migration guide
+
+With the switch from using grep's Extended regex to match files to the natively supported workflow glob pattern matching snytax introduced in [v13](https://github.com/tj-actions/changed-files/releases/tag/v13) you'll need to modify patterns used to match `files`.
+
+**BEFORE**
+
+```yml
+...
+
+      - name: Get specific changed files
+        id: changed-files-specific
+        uses: tj-actions/changed-files@v12.2
+        with:
+          files: |
+            \.sh$
+            .(sql|py)$
+            ^(mynewfile|custom)
+```
+
+**AFTER**
+
+```yml
+...
+
+      - name: Get specific changed files
+        id: changed-files-specific
+        uses: tj-actions/changed-files@v18.4
+        with:
+          files: |
+            *.sh
+            *.sql
+            *.py
+            mynewfile
+            custom/**
+```
+
 ## Credits
 
 This package was created with [Cookiecutter](https://github.com/cookiecutter/cookiecutter).

action.yml

@@ -147,11 +147,12 @@ runs:
         INPUT_PATH: ${{ inputs.path }}
         INPUT_USE_FORK_POINT: ${{ inputs.use_fork_point }}
     - name: Glob match
-      uses: tj-actions/glob@v7.5
+      uses: tj-actions/glob@v7.14
       id: glob
       with:
         files: ${{ inputs.files }}
         files-separator: ${{ inputs.files_separator }}
+        escape-paths: true
         excluded-files: ${{ inputs.files_ignore }}
         excluded-files-separator: ${{ inputs.files_ignore_separator }}
         files-from-source-file: ${{ inputs.files_from_source_file }}
@@ -159,7 +160,7 @@ runs:
         working-directory: ${{ inputs.path }}
         base-sha: ${{ steps.changed-files-diff-sha.outputs.previous_sha }}
         sha: ${{ steps.changed-files-diff-sha.outputs.current_sha }}
-        include-deleted-files: "true"
+        include-deleted-files: true
         separator: "|"
     - run: |
         bash $GITHUB_ACTION_PATH/entrypoint.sh

diff-sha.sh

@@ -52,10 +52,13 @@ if [[ -z $GITHUB_BASE_REF ]]; then
   CURRENT_BRANCH=$TARGET_BRANCH
 
   if [[ -z $INPUT_BASE_SHA ]]; then
+    git fetch --no-tags -u --progress --depth=2 temp_changed_files "${CURRENT_BRANCH}":"${CURRENT_BRANCH}" && exit_status=$? || exit_status=$?
+
     if [[ $(git rev-list --count HEAD) -gt 1 ]]; then
       PREVIOUS_SHA=$(git rev-list --no-merges -n 1 HEAD^1 2>&1) && exit_status=$? || exit_status=$?
     else
       PREVIOUS_SHA=$CURRENT_SHA
+      echo "Initial commit detected"
     fi
   else
     PREVIOUS_SHA=$INPUT_BASE_SHA && exit_status=$? || exit_status=$?