Merge pull request #666 from tj-actions/chore/remove-redundant-since-last-remote-input

chore: remove redundant since last remote commit input

.github/workflows/submodule-sync.yml

@@ -19,7 +19,7 @@ jobs:
           git submodule update --remote --recursive
       
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v4.1.2
+        uses: peter-evans/create-pull-request@v4.1.3
         with:
           title: "Updated submodule"
           branch: "chore/update-submodule"

.github/workflows/sync-release-version.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           output: 'HISTORY.md'
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v4.1.2
+        uses: peter-evans/create-pull-request@v4.1.3
         with:
           base: "main"
           title: "Upgraded to ${{ steps.sync-release-version.outputs.new_version }}"

.github/workflows/test.yml

@@ -140,7 +140,7 @@ jobs:
         uses: ./
       
       - name: Exit with 1 if no error is raised
-        if: github.event_name == 'pull_request' && steps.changed-files.outcome != 'failure'
+        if: steps.changed-files.outcome != 'failure' && github.event.action == 'closed'
         run: |
           echo "Expected: (failure) got ${{ steps.changed-files.outcome }}"
           exit 1
@@ -270,6 +270,10 @@ jobs:
         with:
           submodules: true
           fetch-depth: 0
+      - name: Dump GitHub context
+        env:
+          GITHUB_CONTEXT: ${{ toJson(github) }}
+        run: echo "$GITHUB_CONTEXT"
       - name: Run changed-files with defaults
         id: changed-files
         uses: ./
@@ -291,6 +295,17 @@ jobs:
           echo "Your README.md has been modified ${{ steps.changed-files.outputs.modified_files }}."
         shell:
           bash
+      - name: Run changed-files with quotepath disabled for single path
+        id: changed-files-quotepath-specific
+        uses: ./
+        with:
+          files: test/test-è.txt
+          quotepath: "false"
+      - name: Show output
+        run: |
+          echo '${{ toJSON(steps.changed-files-quotepath-specific.outputs) }}'
+        shell:
+          bash
       - name: Run changed-files with quotepath disabled
         id: changed-files-quotepath
         uses: ./
@@ -801,11 +816,6 @@ jobs:
           echo '${{ toJSON(steps.changed-files-custom-sha.outputs) }}'
         shell:
           bash
-      - name: Run changed-files with since_last_remote_commit set to true
-        id: changed-files-since-last-remote-commit
-        uses: ./
-        with:
-          since_last_remote_commit: 'true'
       - name: Show output
         run: |
           echo '${{ toJSON(steps.changed-files-since-last-remote-commit.outputs) }}'

.github/workflows/update-readme.yml

@@ -31,7 +31,7 @@ jobs:
 
       - name: Create Pull Request
         if: failure()
-        uses: peter-evans/create-pull-request@v4.1.2
+        uses: peter-evans/create-pull-request@v4.1.3
         with:
           base: "main"
           title: "Updated README.md"

HISTORY.md

@@ -1,12 +1,35 @@
 # Changelog
 
+## [v31.0.2](https://github.com/tj-actions/changed-files/tree/v31.0.2) (2022-09-29)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v31...v31.0.2)
+
+## [v31](https://github.com/tj-actions/changed-files/tree/v31) (2022-09-29)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v31.0.1...v31)
+
+**Closed issues:**
+
+- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
+
+**Merged pull requests:**
+
+- chore: add back ability to fetch target branch history [\#654](https://github.com/tj-actions/changed-files/pull/654) ([jackton1](https://github.com/jackton1))
+- chore\(deps\): update peter-evans/create-pull-request action to v4.1.3 [\#653](https://github.com/tj-actions/changed-files/pull/653) ([renovate[bot]](https://github.com/apps/renovate))
+- Upgraded to v31.0.1 [\#652](https://github.com/tj-actions/changed-files/pull/652) ([jackton1](https://github.com/jackton1))
+
+## [v31.0.1](https://github.com/tj-actions/changed-files/tree/v31.0.1) (2022-09-25)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v31.0.0...v31.0.1)
+
+**Merged pull requests:**
+
+- fix: bug with force pushed commits [\#651](https://github.com/tj-actions/changed-files/pull/651) ([jackton1](https://github.com/jackton1))
+- Upgraded to v31.0.0 [\#650](https://github.com/tj-actions/changed-files/pull/650) ([jackton1](https://github.com/jackton1))
+
 ## [v31.0.0](https://github.com/tj-actions/changed-files/tree/v31.0.0) (2022-09-25)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v31...v31.0.0)
-
-## [v31](https://github.com/tj-actions/changed-files/tree/v31) (2022-09-25)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v30.0.0...v31)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v30...v31.0.0)
 
 **Merged pull requests:**
 
@@ -19,23 +42,19 @@
 - chore: update broken link [\#642](https://github.com/tj-actions/changed-files/pull/642) ([jackton1](https://github.com/jackton1))
 - Upgraded to v30.0.0 [\#641](https://github.com/tj-actions/changed-files/pull/641) ([jackton1](https://github.com/jackton1))
 
-## [v30.0.0](https://github.com/tj-actions/changed-files/tree/v30.0.0) (2022-09-24)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v30...v30.0.0)
-
 ## [v30](https://github.com/tj-actions/changed-files/tree/v30) (2022-09-24)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29.0.9...v30)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v30.0.0...v30)
+
+## [v30.0.0](https://github.com/tj-actions/changed-files/tree/v30.0.0) (2022-09-24)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29...v30.0.0)
 
 **Fixed bugs:**
 
 - \[BUG\] Can't get all changed files after pushing new commit [\#639](https://github.com/tj-actions/changed-files/issues/639)
 - \[BUG\] Add support for pull request close event with merge set to true [\#635](https://github.com/tj-actions/changed-files/issues/635)
 
-**Closed issues:**
-
-- Dependency Dashboard [\#27](https://github.com/tj-actions/changed-files/issues/27)
-
 **Merged pull requests:**
 
 - feat: add support for closed pull requests with merge true [\#640](https://github.com/tj-actions/changed-files/pull/640) ([jackton1](https://github.com/jackton1))
@@ -45,13 +64,13 @@
 - chore\(deps\): update codacy/codacy-analysis-cli-action action to v4.2.0 [\#634](https://github.com/tj-actions/changed-files/pull/634) ([renovate[bot]](https://github.com/apps/renovate))
 - Upgraded to v29.0.9 [\#633](https://github.com/tj-actions/changed-files/pull/633) ([jackton1](https://github.com/jackton1))
 
-## [v29.0.9](https://github.com/tj-actions/changed-files/tree/v29.0.9) (2022-09-20)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29...v29.0.9)
-
 ## [v29](https://github.com/tj-actions/changed-files/tree/v29) (2022-09-20)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29.0.8...v29)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29.0.9...v29)
+
+## [v29.0.9](https://github.com/tj-actions/changed-files/tree/v29.0.9) (2022-09-20)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v29.0.8...v29.0.9)
 
 **Implemented enhancements:**
 
@@ -1497,7 +1516,7 @@
 
 ## [v7](https://github.com/tj-actions/changed-files/tree/v7) (2021-06-09)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v7)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v7)
 
 **Closed issues:**
 
@@ -1513,13 +1532,13 @@
 - Update tj-actions/sync-release-version action to v8.7 [\#86](https://github.com/tj-actions/changed-files/pull/86) ([renovate[bot]](https://github.com/apps/renovate))
 - Upgraded to v6.3 [\#85](https://github.com/tj-actions/changed-files/pull/85) ([jackton1](https://github.com/jackton1))
 
-## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
-
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.3...v6)
-
 ## [v6.3](https://github.com/tj-actions/changed-files/tree/v6.3) (2021-05-26)
 
-[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6.3)
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6...v6.3)
+
+## [v6](https://github.com/tj-actions/changed-files/tree/v6) (2021-05-26)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v6.2...v6)
 
 **Merged pull requests:**
 

README.md

@@ -156,9 +156,8 @@ Support this project with a :star:
 |                  sha                   |        `string`        |  `true`  |  `${{ github.sha }}`  |                                                                                                                           Specify a different <br> commit SHA <br> used for <br> comparing changes                                                                                                                            |
 |               base\_sha                |        `string`        | `false`  |                       |                                                                                                                         Specify a different <br> base commit SHA <br> used for <br> comparing changes                                                                                                                         |
 |                  path                  |        `string`        | `false`  |         `'.'`         |                                                                                                                              Relative path under <br> `GITHUB_WORKSPACE` <br> to the repository                                                                                                                               |
-|      since\_last\_remote\_commit       |       `boolean`        | `false`  |        `false`        |       Use the last commit on the remote <br> branch as the `base_sha` <br> (Defaults to the last commit <br> on the target branch for Pull requests <br> or the previous commit <br> on the current branch <br> for push events). <br /> **NOTE:** This requires <br /> `fetch-depth: 0` <br /> with `actions/checkout@v3`        |
 |               quotepath                |       `boolean`        | `false`  |        `true`         |                                                                                                                                Output filenames completely verbatim by setting this to `false`                                                                                                                                |
-|             diff\_relative             |       `boolean`        | `false`  |                       |                                                                                                                       Exclude changes outside the current directory and show pathnames relative to it.                                                                                                                        |
+|             diff\_relative             |       `boolean`        | `false`  |                       |                                                                                                                       Exclude changes outside the current directory and show pathnames relative to it. **NOTE:** This requires you to specify the top level directory via the `path` input.                                                                                                                     |
 |               dir\_names               |       `boolean`        | `false`  |        `false`        |                                                                                        Output unique changed directories instead of filenames. <br> **NOTE:** This returns `.` for <br> changed files located in the root of the project.                                                                                         |
 |                  json                  |       `boolean`        | `false`  |        `false`        |                                                                                                                            Output changed files in JSON format which can be used for [matrix jobs](https://github.com/tj-actions/changed-files/blob/main/.github/workflows/manual-matrix-test.yml).                                                                                                                             |
 |                  since                  |       `string`        | `false`  |                |                                                                                                                            Get changed files for commits whose timestamp is older than the given time.                                                                                                                             |
@@ -287,12 +286,6 @@ Support this project with a :star:
             echo "$file was added"
           done
 
-      - name: Run changed-files using the last commit on the remote branch
-        id: changed-files-since-last-remote-commit
-        uses: tj-actions/changed-files@v31
-        with:
-          since_last_remote_commit: "true"
-
       - name: Run changed-files with quotepath disabled
         id: changed-files-quotepath
         uses: tj-actions/changed-files@v31
@@ -387,6 +380,7 @@ This package was created with [Cookiecutter](https://github.com/cookiecutter/coo
 
 *   [tj-actions/glob](https://github.com/tj-actions/glob)
 *   [tj-actions/demo](https://github.com/tj-actions/demo)
+*   [tj-actions/release-tagger](https://github.com/tj-actions/release-tagger)
 
 ## Report Bugs
 

action.yml

@@ -50,10 +50,6 @@ inputs:
   base_sha:
     description: "Specify a base commit SHA on used for comparing changes"
     required: false
-  since_last_remote_commit:
-    description: "Use the last commit on the remote branch as the base_sha for push event."
-    required: false
-    default: "false"
   since:
     description: "Get changed files for commits whose timestamp is older than the given time"
     required: false
@@ -165,7 +161,6 @@ runs:
         INPUT_BASE_SHA: ${{ inputs.base_sha }}
         INPUT_SHA: ${{ inputs.sha }}
         INPUT_PATH: ${{ inputs.path }}
-        INPUT_SINCE_LAST_REMOTE_COMMIT: ${{ inputs.since_last_remote_commit }}
     - run: |
         # "Calculate the sha..."
         bash $GITHUB_ACTION_PATH/get-sha.sh

diff-sha.sh

@@ -62,6 +62,7 @@ if [[ -z $GITHUB_BASE_REF ]]; then
   CURRENT_BRANCH=$TARGET_BRANCH && exit_status=$? || exit_status=$?
 
   if [[ -z $INPUT_BASE_SHA ]]; then
+    git fetch --no-tags -u --progress origin --depth=2 "${TARGET_BRANCH}":"${TARGET_BRANCH}" && exit_status=$? || exit_status=$?
     PREVIOUS_SHA=""
 
     if [[ "$GITHUB_EVENT_FORCED" == "false" ]]; then
@@ -105,9 +106,11 @@ else
   echo "::debug::GITHUB_BASE_REF: $TARGET_BRANCH..."
 
   if [[ -z $INPUT_BASE_SHA ]]; then
+    git fetch --no-tags -u --progress origin --depth=1 "${TARGET_BRANCH}":"${TARGET_BRANCH}" && exit_status=$? || exit_status=$?
     PREVIOUS_SHA=$GITHUB_PULL_REQUEST_BASE_SHA && exit_status=$? || exit_status=$?
     echo "::debug::Previous SHA: $PREVIOUS_SHA"
   else
+    git fetch --no-tags -u --progress origin --depth=1 "$(git rev-parse --verify "$INPUT_BASE_SHA")" && exit_status=$? || exit_status=$?
     PREVIOUS_SHA=$INPUT_BASE_SHA
     TARGET_BRANCH=$(git name-rev --name-only "$PREVIOUS_SHA" 2>&1) && exit_status=$? || exit_status=$?
     echo "::debug::Previous SHA: $PREVIOUS_SHA"

get-base-sha.sh

@@ -21,18 +21,4 @@ if [[ -n "$INPUT_SINCE" ]]; then
   echo "::set-output name=base_sha::$BASE_SHA"
 elif [[ -n "$INPUT_BASE_SHA" ]]; then
   echo "::set-output name=base_sha::$INPUT_BASE_SHA"
-elif [[ "$INPUT_SINCE_LAST_REMOTE_COMMIT" == "true" ]]; then
-  LAST_REMOTE_COMMIT=""
-
-  if [[ "$GITHUB_EVENT_FORCED" == "false" ]]; then
-    LAST_REMOTE_COMMIT=$GITHUB_EVENT_BEFORE
-  fi
-
-  if [[ -z "$LAST_REMOTE_COMMIT" || "$LAST_REMOTE_COMMIT" == "0000000000000000000000000000000000000000" ]]; then
-    LAST_REMOTE_COMMIT=$(git rev-parse "$(git branch -r --sort=-committerdate | head -1 | xargs)")
-  fi
-  if [[ "$INPUT_SHA" == "$LAST_REMOTE_COMMIT" ]]; then
-    LAST_REMOTE_COMMIT=$(git rev-parse "$INPUT_SHA^1")
-  fi
-  echo "::set-output name=base_sha::$LAST_REMOTE_COMMIT"
 fi

test/test-è.txt

@@ -1 +1 @@
-This is a test file.
+This is a test file with non ascii character filename.