fix: add warning message when unable to list submodules (#1304)

Co-authored-by: GitHub Action <action@github.com>

.github/workflows/test.yml

@@ -66,7 +66,7 @@ jobs:
           yarn install
 
       - name: Run eslint on changed files
-        uses: tj-actions/eslint-changed-files@v19
+        uses: tj-actions/eslint-changed-files@v20
         if: github.event_name == 'pull_request'
         with:
           token: ${{ secrets.PAT_TOKEN }}

HISTORY.md

@@ -1,5 +1,56 @@
 # Changelog
 
+# [37.0.1](https://github.com/tj-actions/changed-files/compare/v37.0.0...v37.0.1) - (2023-06-24)
+
+## <!-- 1 -->🐛 Bug Fixes
+
+- Error using current path to determine the .git dir location ([#1299](https://github.com/tj-actions/changed-files/issues/1299)) ([e5efec4](https://github.com/tj-actions/changed-files/commit/e5efec47f620e0fde64a1ad8f53bbf53d51a8c97))  - (Tonye Jack)
+
+## <!-- 9 -->⬆️ Upgrades
+
+- Upgraded to v37 ([#1298](https://github.com/tj-actions/changed-files/issues/1298))
+
+Co-authored-by: jackton1 <jackton1@users.noreply.github.com> ([d6d7cb2](https://github.com/tj-actions/changed-files/commit/d6d7cb291e28bba32464fbbf0d13c7f6c2c75de1))  - (tj-actions[bot])
+
+# [37.0.0](https://github.com/tj-actions/changed-files/compare/v36.4.1...v37.0.0) - (2023-06-23)
+
+## <!-- 0 -->🚀 Features
+
+- Add support for retrieving changed files via github rest api ([#1289](https://github.com/tj-actions/changed-files/issues/1289)) ([fd5b3a4](https://github.com/tj-actions/changed-files/commit/fd5b3a411da53db8da7b4b197cc1b1066dcd5360))  - (Tonye Jack)
+
+## <!-- 17 -->➖ Remove
+
+- Deprecated dir_names_exclude_root ([#1291](https://github.com/tj-actions/changed-files/issues/1291)) ([faa5db4](https://github.com/tj-actions/changed-files/commit/faa5db4b1d5c904bd14ba8dc0d429e2c257c9638))  - (Tonye Jack)
+
+## <!-- 26 -->🔄 Update
+
+- Updated README.md ([#1295](https://github.com/tj-actions/changed-files/issues/1295))
+
+Co-authored-by: jackton1 <jackton1@users.noreply.github.com> ([a553a02](https://github.com/tj-actions/changed-files/commit/a553a029f5a46a8e74f782b41db046e63aab0cfb))  - (tj-actions[bot])
+- Updated README.md ([#1292](https://github.com/tj-actions/changed-files/issues/1292))
+
+Co-authored-by: repo-ranger[bot] <repo-ranger[bot]@users.noreply.github.com> ([63f203d](https://github.com/tj-actions/changed-files/commit/63f203d400de5479b07e8a01487881309f2bc0ce))  - (tj-actions[bot])
+
+## <!-- 7 -->⚙️ Miscellaneous Tasks
+
+- Update README.md ([5817a9e](https://github.com/tj-actions/changed-files/commit/5817a9efb0d7cc34b917d8146ea10b9f32044968))  - (Tonye Jack)
+- **deps:** Lock file maintenance ([#1297](https://github.com/tj-actions/changed-files/issues/1297)) ([33d50af](https://github.com/tj-actions/changed-files/commit/33d50af03f5e8e0914e7ddea9455ca6cde2033b1))  - (renovate[bot])
+- Use input api url ([#1293](https://github.com/tj-actions/changed-files/issues/1293)) ([a4cd522](https://github.com/tj-actions/changed-files/commit/a4cd522ee2e5d7999bb102867e6d806e59861c52))  - (Tonye Jack)
+- **deps:** Lock file maintenance ([#1290](https://github.com/tj-actions/changed-files/issues/1290)) ([c4a394a](https://github.com/tj-actions/changed-files/commit/c4a394a9cfbbfcea1d864b5d6c9f9aa2b7960a9b))  - (renovate[bot])
+- **deps:** Update tj-actions/verify-changed-files action to v16 ([#1288](https://github.com/tj-actions/changed-files/issues/1288)) ([50ae49b](https://github.com/tj-actions/changed-files/commit/50ae49b0e4dc2c5bdccb7aad26373561c753b17f))  - (renovate[bot])
+- Update manual-test.yml ([588d46e](https://github.com/tj-actions/changed-files/commit/588d46e858ff7c814f5a26458ae8794b715d690a))  - (Tonye Jack)
+- Update README.md ([bdeaa91](https://github.com/tj-actions/changed-files/commit/bdeaa9108ce22a3e92aefbe165c85ea29b839a24))  - (Tonye Jack)
+- Update matrix-test.yml ([4d8812d](https://github.com/tj-actions/changed-files/commit/4d8812d205c7d0bca52560321514947f65c7a2f9))  - (Tonye Jack)
+- **deps:** Lock file maintenance ([#1287](https://github.com/tj-actions/changed-files/issues/1287)) ([668fd3a](https://github.com/tj-actions/changed-files/commit/668fd3a7139e499b321f1889c2f1a90b508da43e))  - (renovate[bot])
+- **deps:** Lock file maintenance ([#1285](https://github.com/tj-actions/changed-files/issues/1285)) ([b952f3b](https://github.com/tj-actions/changed-files/commit/b952f3beb3bb65ec19163628da458efb10e5f3d6))  - (renovate[bot])
+- **deps:** Lock file maintenance ([#1284](https://github.com/tj-actions/changed-files/issues/1284)) ([ce8bc5d](https://github.com/tj-actions/changed-files/commit/ce8bc5d49a2cf03a217066239554d467140a3054))  - (renovate[bot])
+
+## <!-- 9 -->⬆️ Upgrades
+
+- Upgraded to v36.4.1 ([#1283](https://github.com/tj-actions/changed-files/issues/1283))
+
+Co-authored-by: jackton1 <jackton1@users.noreply.github.com> ([9ff3603](https://github.com/tj-actions/changed-files/commit/9ff36033594327f40a8c22612579a3604e90fc7a))  - (tj-actions[bot])
+
 # [36.4.1](https://github.com/tj-actions/changed-files/compare/v36.4.0...v36.4.1) - (2023-06-19)
 
 ## <!-- 1 -->🐛 Bug Fixes

README.md

@@ -102,12 +102,13 @@ jobs:
     # - A maximum of 3000 files can be returned.
     runs-on: ubuntu-latest  # windows-latest | macos-latest
     name: Test changed-files
+    if: github.event_name != 'push'
     permissions:
       pull-requests: read
     steps:
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
 
       - name: List all changed files
         run: |
@@ -129,7 +130,7 @@ jobs:
 
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         
         # To compare changes between the current commit and the last pushed remote commit set `since_last_remote_commit: true`. e.g
         # with:
@@ -151,7 +152,7 @@ jobs:
 
       - name: Get changed files in the docs folder
         id: changed-files-specific
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           files: docs/*.{js,html}  # Alternatively using: `docs/**` or `docs`
 
@@ -171,7 +172,7 @@ jobs:
   
       - name: Get all changed .js file(s) or any file in the static folder excluding the docs folder
         id: changed-files-excluded
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           files: |
             **.js
@@ -194,7 +195,7 @@ jobs:
 
       - name: Get all test, doc and src files that have changed
         id: changed-files-yaml
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           files_yaml: |
             doc:
@@ -360,7 +361,7 @@ The format of the version string is as follows:
 ...
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
 ...
 ```
 
@@ -373,7 +374,7 @@ The format of the version string is as follows:
 ...
     - name: Get all changed files and use a comma separator in the output
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         separator: ","
 ...
@@ -390,7 +391,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
 
     - name: List all added files
       run: |
@@ -411,7 +412,7 @@ See [outputs](#outputs) for a list of all available outputs.
 ...
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
 
     - name: Run a step if my-file.txt was modified
       if: contains(steps.changed-files.outputs.modified_files, 'my-file.txt')
@@ -471,7 +472,7 @@ See [outputs](#outputs) for a list of all available outputs.
 ...
     - name: Get changed files
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         files: |
           my-file.txt
@@ -494,7 +495,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed files
       id: changed-files-specific
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         files: |
           my-file.txt
@@ -541,7 +542,7 @@ See [outputs](#outputs) for a list of all available outputs.
 ...
     - name: Get changed files using a source file or list of file(s) to populate to files input.
       id: changed-files-specific-source-file
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         files_from_source_file: test/changed-files-list.txt
 ...
@@ -558,7 +559,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed files using a source file or list of file(s) to populate to files input and optionally specify more files.
       id: changed-files-specific-source-file-and-specify-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         files_from_source_file: |
           test/changed-files-list.txt
@@ -579,7 +580,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed files using a different SHA
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         sha: ${{ github.event.pull_request.head.sha }}
 ...
@@ -596,7 +597,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed files using a different base SHA
       id: changed-files
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         base_sha: ${{ github.event.pull_request.base.sha }}
 ...
@@ -628,11 +629,11 @@ jobs:
 
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
 
       - name: Get changed files in the .github folder
         id: changed-files-specific
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           base_sha: ${{ steps.get-base-sha.outputs.base_sha }}
           files: .github/**
@@ -662,7 +663,7 @@ See [inputs](#inputs) for more information.
 
     - name: Run changed-files with defaults in dir1
       id: changed-files-for-dir1
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         path: dir1
 
@@ -685,7 +686,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Run changed-files with quotepath disabled
       id: changed-files-quotepath
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         quotepath: "false"
 
@@ -724,7 +725,7 @@ See [inputs](#inputs) for more information.
 
       - name: Run changed-files with the commit of the last successful test workflow run
         id: changed-files-base-sha-push
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           base_sha: ${{ steps.last_successful_commit_push.outputs.base }}
 ...
@@ -751,7 +752,7 @@ See [inputs](#inputs) for more information.
 
       - name: Run changed-files with the commit of the last successful test workflow run on main
         id: changed-files-base-sha-pull-request
-        uses: tj-actions/changed-files@v36
+        uses: tj-actions/changed-files@v37
         with:
           base_sha: ${{ steps.last_successful_commit_pull_request.outputs.base }}
 ...
@@ -775,7 +776,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Run changed-files with dir_names
       id: changed-files-dir-names
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         dir_names: "true"
 ...
@@ -792,7 +793,7 @@ See [inputs](#inputs) for more information.
 ...
     - name: Run changed-files with json output
       id: changed-files-json
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         json: "true"
 ...
@@ -809,13 +810,13 @@ See [inputs](#inputs) for more information.
 ...
     - name: Get changed-files since 2022-08-19
       id: changed-files-since
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         since: "2022-08-19"
 
     - name: Get changed-files until 2022-08-20
       id: changed-files-until
-      uses: tj-actions/changed-files@v36
+      uses: tj-actions/changed-files@v37
       with:
         until: "2022-08-20"
 ...

dist/index.js

@@ -1641,7 +1641,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.hasLocalGitDirectory = exports.recoverDeletedFiles = exports.setOutput = exports.getYamlFilePatterns = exports.getFilePatterns = exports.jsonOutput = exports.getDirnameMaxDepth = exports.canDiffCommits = exports.getPreviousGitTag = exports.verifyCommitSha = exports.getParentSha = exports.getRemoteBranchHeadSha = exports.getHeadSha = exports.gitLog = exports.getFilteredChangedFiles = exports.getAllChangedFiles = exports.gitRenamedFiles = exports.gitSubmoduleDiffSHA = exports.getSubmodulePath = exports.gitFetchSubmodules = exports.gitFetch = exports.submoduleExists = exports.isRepoShallow = exports.updateGitGlobalConfig = exports.verifyMinimumGitVersion = void 0;
+exports.hasLocalGitDirectory = exports.recoverDeletedFiles = exports.setOutput = exports.getYamlFilePatterns = exports.getFilePatterns = exports.jsonOutput = exports.getDirnameMaxDepth = exports.canDiffCommits = exports.getPreviousGitTag = exports.verifyCommitSha = exports.getParentSha = exports.getRemoteBranchHeadSha = exports.isInsideWorkTree = exports.getHeadSha = exports.gitLog = exports.getFilteredChangedFiles = exports.getAllChangedFiles = exports.gitRenamedFiles = exports.gitSubmoduleDiffSHA = exports.getSubmodulePath = exports.gitFetchSubmodules = exports.gitFetch = exports.submoduleExists = exports.isRepoShallow = exports.updateGitGlobalConfig = exports.verifyMinimumGitVersion = void 0;
 /*global AsyncIterableIterator*/
 const core = __importStar(__nccwpck_require__(2186));
 const exec = __importStar(__nccwpck_require__(1514));
@@ -1821,12 +1821,13 @@ const isRepoShallow = ({ cwd }) => __awaiter(void 0, void 0, void 0, function* (
 });
 exports.isRepoShallow = isRepoShallow;
 const submoduleExists = ({ cwd }) => __awaiter(void 0, void 0, void 0, function* () {
-    const { stdout, exitCode } = yield exec.getExecOutput('git', ['submodule', 'status'], {
+    const { stdout, exitCode, stderr } = yield exec.getExecOutput('git', ['submodule', 'status'], {
         cwd,
         ignoreReturnCode: true,
         silent: !core.isDebug()
     });
     if (exitCode !== 0) {
+        core.warning(stderr || "Couldn't list submodules");
         return false;
     }
     return stdout.trim() !== '';
@@ -2030,6 +2031,15 @@ const getHeadSha = ({ cwd }) => __awaiter(void 0, void 0, void 0, function* () {
     return stdout.trim();
 });
 exports.getHeadSha = getHeadSha;
+const isInsideWorkTree = ({ cwd }) => __awaiter(void 0, void 0, void 0, function* () {
+    const { stdout } = yield exec.getExecOutput('git', ['rev-parse', '--is-inside-work-tree'], {
+        cwd,
+        ignoreReturnCode: true,
+        silent: !core.isDebug()
+    });
+    return stdout.trim() === 'true';
+});
+exports.isInsideWorkTree = isInsideWorkTree;
 const getRemoteBranchHeadSha = ({ cwd, branch }) => __awaiter(void 0, void 0, void 0, function* () {
     const { stdout } = yield exec.getExecOutput('git', ['rev-parse', `origin/${branch}`], {
         cwd,
@@ -2345,8 +2355,10 @@ const recoverDeletedFiles = ({ inputs, workingDirectory, deletedFiles, sha }) =>
 });
 exports.recoverDeletedFiles = recoverDeletedFiles;
 const hasLocalGitDirectory = ({ workingDirectory }) => __awaiter(void 0, void 0, void 0, function* () {
-    const gitDirectory = path.join(workingDirectory, '.git');
-    return yield exists(gitDirectory);
+    const insideWorkTree = yield (0, exports.isInsideWorkTree)({
+        cwd: workingDirectory
+    });
+    return insideWorkTree;
 });
 exports.hasLocalGitDirectory = hasLocalGitDirectory;
 

package.json

@@ -44,7 +44,7 @@
     "@types/jest": "29.5.2",
     "@types/lodash": "^4.14.195",
     "@types/micromatch": "^4.0.2",
-    "@types/node": "20.2.1",
+    "@types/node": "20.3.1",
     "@types/uuid": "9.0.2",
     "@typescript-eslint/eslint-plugin": "5.60.0",
     "@typescript-eslint/parser": "5.60.0",

src/utils.ts

@@ -209,7 +209,7 @@ export const submoduleExists = async ({
 }: {
   cwd: string
 }): Promise<boolean> => {
-  const {stdout, exitCode} = await exec.getExecOutput(
+  const {stdout, exitCode, stderr} = await exec.getExecOutput(
     'git',
     ['submodule', 'status'],
     {
@@ -220,6 +220,7 @@ export const submoduleExists = async ({
   )
 
   if (exitCode !== 0) {
+    core.warning(stderr || "Couldn't list submodules")
     return false
   }
 
@@ -552,6 +553,24 @@ export const getHeadSha = async ({cwd}: {cwd: string}): Promise<string> => {
   return stdout.trim()
 }
 
+export const isInsideWorkTree = async ({
+  cwd
+}: {
+  cwd: string
+}): Promise<boolean> => {
+  const {stdout} = await exec.getExecOutput(
+    'git',
+    ['rev-parse', '--is-inside-work-tree'],
+    {
+      cwd,
+      ignoreReturnCode: true,
+      silent: !core.isDebug()
+    }
+  )
+
+  return stdout.trim() === 'true'
+}
+
 export const getRemoteBranchHeadSha = async ({
   cwd,
   branch
@@ -1103,6 +1122,9 @@ export const hasLocalGitDirectory = async ({
 }: {
   workingDirectory: string
 }): Promise<boolean> => {
-  const gitDirectory = path.join(workingDirectory, '.git')
-  return await exists(gitDirectory)
+  const insideWorkTree = await isInsideWorkTree({
+    cwd: workingDirectory
+  })
+
+  return insideWorkTree
 }

yarn.lock

@@ -975,16 +975,11 @@
   dependencies:
     "@types/braces" "*"
 
-"@types/node@*":
+"@types/node@*", "@types/node@20.3.1":
   version "20.3.1"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-20.3.1.tgz#e8a83f1aa8b649377bb1fb5d7bac5cb90e784dfe"
   integrity sha512-EhcH/wvidPy1WeML3TtYFGR83UzjxeWRen9V402T8aUGYsCHOmfoisV3ZSg03gAFIbLq8TnWOJ0f4cALtnSEUg==
 
-"@types/node@20.2.1":
-  version "20.2.1"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.2.1.tgz#de559d4b33be9a808fd43372ccee822c70f39704"
-  integrity sha512-DqJociPbZP1lbZ5SQPk4oag6W7AyaGMO6gSfRwq3PWl4PXTwJpRQJhDq4W0kzrg3w6tJ1SwlvGZ5uKFHY13LIg==
-
 "@types/prettier@^2.1.5":
   version "2.7.3"
   resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-2.7.3.tgz#3e51a17e291d01d17d3fc61422015a933af7a08f"
@@ -1575,9 +1570,9 @@ doctrine@^3.0.0:
     esutils "^2.0.2"
 
 electron-to-chromium@^1.4.431:
-  version "1.4.439"
-  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.439.tgz#d0748e8128c18f92354d3412dfb2104c3fb90e8f"
-  integrity sha512-BHpErPSNhb9FB25+OwQP6mCAf3ZXfGbmuvc4LzBNVJwpCcXQJm++LerimocYRG9FRxUVRKZqaB7d0+pImSTPSg==
+  version "1.4.440"
+  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.440.tgz#d3b1eeb36b717eb479a240c0406ac1fa67901762"
+  integrity sha512-r6dCgNpRhPwiWlxbHzZQ/d9swfPaEJGi8ekqRBwQYaR3WmA5VkqQfBWSDDjuJU1ntO+W9tHx8OHV/96Q8e0dVw==
 
 emittery@^0.13.1:
   version "0.13.1"