Strip leading whitespaces (#50)

Co-authored-by: jackton1 <jackton1@users.noreply.github.com>

.github/workflows/test.yml

@@ -45,8 +45,8 @@ jobs:
         uses: ./
         with:
           files: |
-            action.yml
             .github/workflows/test.yml
+            action.yml
       - name: Show output
         run: |
           echo "${{ toJSON(steps.changed-files-specific.outputs) }}"
@@ -55,8 +55,8 @@ jobs:
         uses: ./
         with:
           files: |
-            action.yml
             .github/workflows/test.yml
+            action.yml
           separator: ","
       - name: Show output
         run: |

HISTORY.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## [v5](https://github.com/tj-actions/changed-files/tree/v5) (2021-05-01)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v4.4...v5)
+
+**Merged pull requests:**
+
+- Update README.md [\#48](https://github.com/tj-actions/changed-files/pull/48) ([jackton1](https://github.com/jackton1))
+- Upgraded to v5.3 [\#47](https://github.com/tj-actions/changed-files/pull/47) ([jackton1](https://github.com/jackton1))
+- Fixed bug with all\_changed when array is empty [\#46](https://github.com/tj-actions/changed-files/pull/46) ([jackton1](https://github.com/jackton1))
+- Upgraded to v5.2 [\#45](https://github.com/tj-actions/changed-files/pull/45) ([jackton1](https://github.com/jackton1))
+- Upgraded to v5.1 [\#44](https://github.com/tj-actions/changed-files/pull/44) ([jackton1](https://github.com/jackton1))
+- Upgraded to v5 [\#43](https://github.com/tj-actions/changed-files/pull/43) ([jackton1](https://github.com/jackton1))
+- Upgraded to v5 [\#40](https://github.com/tj-actions/changed-files/pull/40) ([jackton1](https://github.com/jackton1))
+- Switch to using a bash script. [\#39](https://github.com/tj-actions/changed-files/pull/39) ([jackton1](https://github.com/jackton1))
+- Upgraded to v4.4 [\#38](https://github.com/tj-actions/changed-files/pull/38) ([jackton1](https://github.com/jackton1))
+
+## [v4.4](https://github.com/tj-actions/changed-files/tree/v4.4) (2021-05-01)
+
+[Full Changelog](https://github.com/tj-actions/changed-files/compare/v4.3...v4.4)
+
+**Merged pull requests:**
+
+- Update .gitignore [\#36](https://github.com/tj-actions/changed-files/pull/36) ([jackton1](https://github.com/jackton1))
+- Add support for any changed file. [\#35](https://github.com/tj-actions/changed-files/pull/35) ([jackton1](https://github.com/jackton1))
+- Update .gitignore [\#34](https://github.com/tj-actions/changed-files/pull/34) ([jackton1](https://github.com/jackton1))
+- Renamed has\_changed to all\_changed [\#33](https://github.com/tj-actions/changed-files/pull/33) ([jackton1](https://github.com/jackton1))
+- Upgraded to v4.3 [\#32](https://github.com/tj-actions/changed-files/pull/32) ([jackton1](https://github.com/jackton1))
+
 ## [v4.3](https://github.com/tj-actions/changed-files/tree/v4.3) (2021-05-01)
 
 [Full Changelog](https://github.com/tj-actions/changed-files/compare/v4.2...v4.3)

README.md

@@ -3,11 +3,13 @@
 changed-files
 -------------
 
-Get all modified files relative to the default branch or preceding commit.
+Get all modified files relative to the default branch (`pull_request*` events) or last commit (`push` events).
 
 
 ## Features
-- List all files that have changed .
+- List all files that have changed
+  - Between the current pull request branch and the default branch
+  - Between the last commit and the current pushed change.
 - List only a subset of files that can be used to detect changes.
 - Report on a subset of files that have all change.
 - Report on a subset of files that have at least one file change.
@@ -34,6 +36,7 @@ Using the default separator.
 |:-------------------:|:------------:|:------------------------------:|:----------------------------------------:|
 | all_modified_files   |  `string`    |    'new.txt other.png ...'     |  Select all modified files <br /> *i.e a combination of all added, <br />copied and modified files (ACM).*  |
 | all_changed          |  `string`     |     `true OR false`             |  Returns `true` only when the filenames provided using `files` input have all changed |
+| any_changed          |  `string`     |     `true OR false`             |  Returns `true` when any of the filenames provided using `files` input have changed |
 | all_changed_files   |  `string`    |    'new.txt other.png ...'     |  Select all paths (*) <br /> *i.e a combination of all options below.*  |
 | added_files         |  `string`    |    'new.txt other.png ...'     |  Select only files that are Added (A)    |
 | copied_files        |  `string`    |    'new.txt other.png ...'     |  Select only files that are Copied (C)   |
@@ -82,7 +85,7 @@ jobs:
       
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v4.3
+        uses: tj-actions/changed-files@v5
       
       - name: List all modified files
         run: |
@@ -100,11 +103,11 @@ jobs:
       - uses: actions/checkout@v2
       - name: Get changed files using defaults
         id: changed-files
-        uses: tj-actions/changed-files@v4.3
+        uses: tj-actions/changed-files@v5
       
       - name: Get changed files using a comma separator
         id: changed-files-comma
-        uses: tj-actions/changed-files@v4.3
+        uses: tj-actions/changed-files@v5
         with:
           separator: ","
 
@@ -126,7 +129,7 @@ jobs:
 
       - name: Get specific changed files
         id: changed-files-specific
-        uses: tj-actions/changed-files@v4.2
+        uses: tj-actions/changed-files@v5
         with:
           files: |
             my-file.txt
@@ -138,10 +141,15 @@ jobs:
             ^(mynewfile|custom)
 
        - name: Run step if all files listed above have changed
-         if: steps.changed-files-specific.outputs.all_changed
+         if: steps.changed-files-specific.outputs.all_changed == 'true'
          run: |
            echo "Both my-file.txt and test.txt have changed."
         
+       - name: Run step if any of the listed files above change
+         if: steps.changed-files-specific.outputs.any_changed == 'true'
+         run: |
+           echo "Either my-file.txt or test.txt have changed."
+        
 ```
 
 ### Running [pre-commit](https://pre-commit.com/) on all modified files
@@ -155,7 +163,7 @@ jobs:
       
       - name: Get changed files
         id: changed-files
-        uses: tj-actions/changed-files@v4.3
+        uses: tj-actions/changed-files@v5
 
       - name: Pre-commit
         uses: pre-commit/action@v2.0.0

action.yml

@@ -54,89 +54,111 @@ runs:
   steps:
     - id: changed_files
       run: |
-        echo "Getting head sha..."
+        set -e
 
+        export INPUT_FILES="${{ inputs.files }}"
+        export INPUT_SEPARATOR="${{ inputs.separator }}"
+        echo "Getting head sha..."
         if [[ -z $GITHUB_BASE_REF ]]; then
           HEAD_SHA=$(git rev-parse HEAD^1 || true)
         else
           TARGET_BRANCH=${GITHUB_BASE_REF}
-          git fetch --depth=1 origin ${TARGET_BRANCH}:${TARGET_BRANCH}
-          HEAD_SHA=$(git rev-parse ${TARGET_BRANCH} || true)
+          git fetch --depth=1 origin "${TARGET_BRANCH}":"${TARGET_BRANCH}"
+          HEAD_SHA=$(git rev-parse "${TARGET_BRANCH}" || true)
         fi
-        
-        INPUT_FILES="${{ inputs.files }}"
-
+        echo "Using head sha: $HEAD_SHA..."
         if [[ -z "$INPUT_FILES" ]]; then
-
           echo "Getting diff..."
-
-          ADDED=$(git diff --diff-filter=A --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          COPIED=$(git diff --diff-filter=C --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          DELETED=$(git diff --diff-filter=D --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          MODIFIED=$(git diff --diff-filter=M --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          RENAMED=$(git diff --diff-filter=R --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          CHANGED=$(git diff --diff-filter=T --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          UNMERGED=$(git diff --diff-filter=U --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          UNKNOWN=$(git diff --diff-filter=X --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          ALL_CHANGED=$(git diff --diff-filter='*ACDMRTUX' --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
-          ALL_MODIFIED_FILES=$(git diff --diff-filter='ACM' --name-only "$HEAD_SHA" | tr "\n" "${{ inputs.separator }}" | sed -E 's/(${{ inputs.separator }})$//')
+          ADDED=$(git diff --diff-filter=A --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          COPIED=$(git diff --diff-filter=C --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          DELETED=$(git diff --diff-filter=D --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          MODIFIED=$(git diff --diff-filter=M --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          RENAMED=$(git diff --diff-filter=R --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          CHANGED=$(git diff --diff-filter=T --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          UNMERGED=$(git diff --diff-filter=U --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          UNKNOWN=$(git diff --diff-filter=X --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          ALL_CHANGED=$(git diff --diff-filter="*ACDMRTUX" --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
+          ALL_MODIFIED_FILES=$(git diff --diff-filter="ACM" --name-only "$HEAD_SHA" | tr "\n" "$INPUT_SEPARATOR" | sed -E "s/($INPUT_SEPARATOR)$//")
         else
-          ADDED=()
-          COPIED=()
-          DELETED=()
-          MODIFIED=()
-          RENAMED=()
-          CHANGED=()
-          UNMERGED=()
-          UNKNOWN=()
-          ALL_CHANGED=()
-          ALL_MODIFIED_FILES=()
-
+          ADDED_ARRAY=()
+          COPIED_ARRAY=()
+          DELETED_ARRAY=()
+          MODIFIED_ARRAY=()
+          RENAMED_ARRAY=()
+          CHANGED_ARRAY=()
+          UNMERGED_ARRAY=()
+          UNKNOWN_ARRAY=()
+          ALL_CHANGED_ARRAY=()
+          ALL_MODIFIED_FILES_ARRAY=()
           for path in ${INPUT_FILES}
           do
             echo "Checking for file changes: \"${path}\"..."
-            ADDED+=$(git diff --diff-filter=A --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            COPIED+=$(git diff --diff-filter=C --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            DELETED+=$(git diff --diff-filter=D --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            MODIFIED+=$(git diff --diff-filter=M --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            RENAMED+=$(git diff --diff-filter=R --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            CHANGED+=$(git diff --diff-filter=T --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            UNMERGED+=$(git diff --diff-filter=U --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            UNKNOWN+=$(git diff --diff-filter=X --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            ALL_CHANGED+=$(git diff --diff-filter='*ACDMRTUX' --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
-            ALL_MODIFIED_FILES+=$(git diff --diff-filter='ACM' --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s${{ inputs.separator }}" || true)
+            IFS=" "
+            ADDED_ARRAY+=("$(git diff --diff-filter=A --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            COPIED_ARRAY+=("$(git diff --diff-filter=C --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            DELETED_ARRAY+=("$(git diff --diff-filter=D --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            MODIFIED_ARRAY+=("$(git diff --diff-filter=M --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            RENAMED_ARRAY+=("$(git diff --diff-filter=R --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            CHANGED_ARRAY+=("$(git diff --diff-filter=T --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            UNMERGED_ARRAY+=("$(git diff --diff-filter=U --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            UNKNOWN_ARRAY+=("$(git diff --diff-filter=X --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            ALL_CHANGED_ARRAY+=("$(git diff --diff-filter="*ACDMRTUX" --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
+            ALL_MODIFIED_FILES_ARRAY+=("$(git diff --diff-filter="ACM" --name-only "$HEAD_SHA" | grep -E "(${path})" | xargs printf "%s$INPUT_SEPARATOR" || true)")
           done
 
-          ADDED=$(echo "$ADDED" | sed -E 's/(${{ inputs.separator }})$//')
-          COPIED=$(echo $COPIED | sed -E 's/(${{ inputs.separator }})$//')
-          DELETED=$(echo "$DELETED" | sed -E 's/(${{ inputs.separator }})$//')
-          MODIFIED=$(echo "$MODIFIED" | sed -E 's/(${{ inputs.separator }})$//')
-          RENAMED=$(echo "$RENAMED" | sed -E 's/(${{ inputs.separator }})$//')
-          CHANGED=$(echo "$CHANGED" | sed -E 's/(${{ inputs.separator }})$//')
-          UNMERGED=$(echo "$UNMERGED" | sed -E 's/(${{ inputs.separator }})$//')
-          UNKNOWN=$(echo "$UNKNOWN" | sed -E 's/(${{ inputs.separator }})$//')
-          ALL_CHANGED=$(echo "$ALL_CHANGED" | sed -E 's/(${{ inputs.separator }})$//')
-          ALL_MODIFIED_FILES=$(echo "$ALL_MODIFIED_FILES" | sed -E 's/(${{ inputs.separator }})$//')
-          
-          OUTPUT_ALL_MODIFIED_FILES=$(echo $ALL_MODIFIED_FILES | sed "s/${{ inputs.separator }}/ /g")
-          ALL_INPUT_FILES=$(echo $INPUT_FILES | sed "s/\n/ /g")
+          ADDED=$(echo "${ADDED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          COPIED=$(echo "${COPIED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          DELETED=$(echo "${DELETED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          MODIFIED=$(echo "${MODIFIED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          RENAMED=$(echo "${RENAMED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          CHANGED=$(echo "${CHANGED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          UNMERGED=$(echo "${UNMERGED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          UNKNOWN=$(echo "${UNKNOWN_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          ALL_CHANGED=$(echo "${ALL_CHANGED_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
+          ALL_MODIFIED_FILES=$(echo "${ALL_MODIFIED_FILES_ARRAY[@]}" | sed -E "s/($INPUT_SEPARATOR)$//" | xargs)
 
-          IFS=$' ' SORTED_INPUT_FILES=($(sort <<<"${ALL_INPUT_FILES[*]}"))
-          IFS=$' ' SORTED_OUTPUT_ALL_MODIFIED_FILES=($(sort <<<"${OUTPUT_ALL_MODIFIED_FILES[*]}"))
+        fi
+
+        echo "Added files: $ADDED"
+        echo "Copied files: $COPIED"
+        echo "Deleted files: $DELETED"
+        echo "Modified files: $MODIFIED"
+        echo "Renamed files: $RENAMED"
+        echo "Changed files: $CHANGED"
+        echo "Unmerged files: $UNMERGED"
+        echo "Unknown files: $UNKNOWN"
+        echo "All changed files: $ALL_CHANGED"
+        echo "All modified files: $ALL_MODIFIED_FILES"
+
+        if [[ -n "$INPUT_FILES" ]]; then
+          # shellcheck disable=SC2001
+          OUTPUT_ALL_MODIFIED_FILES=$(echo "$ALL_MODIFIED_FILES" | sed "s/$INPUT_SEPARATOR/ /g")
+          ALL_INPUT_FILES=$(echo "$INPUT_FILES" | tr "\n" " " | xargs)
           
-          if [[ "${SORTED_INPUT_FILES[*]}" == "${SORTED_OUTPUT_ALL_MODIFIED_FILES[*]}" ]]; then
-            echo "::set-output name=all_changed::true"
-          else
-            echo "::set-output name=all_changed::false"
-          fi
+          echo "Input files: ${ALL_INPUT_FILES[@]}"
+          echo "Output all modified files: ${OUTPUT_ALL_MODIFIED_FILES[@]}"
+
+          SORTED_INPUT_FILES=()
+          SORTED_OUTPUT_ALL_MODIFIED_FILES=()
+
+          IFS=" " read -r -a SORTED_INPUT_FILES <<< "$(sort <<<"${ALL_INPUT_FILES[*]}")"
+          IFS=" " read -r -a SORTED_OUTPUT_ALL_MODIFIED_FILES <<< "$(sort <<<"${OUTPUT_ALL_MODIFIED_FILES[*]}")"
 
           if [[ ${#SORTED_OUTPUT_ALL_MODIFIED_FILES[@]} -gt 0 ]]; then
             echo "::set-output name=any_changed::true"
+            
+            echo "Sorted input files: ${SORTED_INPUT_FILES[@]}"
+            echo "Sorted output all modified files: ${SORTED_OUTPUT_ALL_MODIFIED_FILES[@]}"
+
+            if [[ "${SORTED_INPUT_FILES[*]}" == "${SORTED_OUTPUT_ALL_MODIFIED_FILES[*]}" ]]; then
+              echo "::set-output name=all_changed::true"
+            else
+              echo "::set-output name=all_changed::false"
+            fi
           else
             echo "::set-output name=any_changed::false"
           fi
         fi
-
         echo "::set-output name=added_files::$ADDED"
         echo "::set-output name=copied_files::$COPIED"
         echo "::set-output name=deleted_files::$DELETED"
@@ -147,6 +169,8 @@ runs:
         echo "::set-output name=unknown_files::$UNKNOWN"
         echo "::set-output name=all_changed_files::$ALL_CHANGED"
         echo "::set-output name=all_modified_files::$ALL_MODIFIED_FILES"
+        unset INPUT_FILES
+        unset INPUT_SEPARATOR
       shell: bash
 
 branding: